Hotfix/sync main - #389
Conversation
Main convert
chore: release main
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the versions and changelogs for the js-sdk, rules, types, and utils packages. The reviewer identified several duplicated or triplicated entries in the changelog files that should be consolidated to maintain a clean release history.
| * **context:** forward all BucketingAttributes to ExperienceManager ([b215167](https://github.com/convertcom/javascript-sdk/commit/b21516727381ce7620bd15e6fac66fc5dd2785c4)) | ||
| * **context:** forward all BucketingAttributes to ExperienceManager ([90e4730](https://github.com/convertcom/javascript-sdk/commit/90e4730386a4cceb9ce35e484654f84f3c33709c)) |
There was a problem hiding this comment.
The bug fix entry for 'forward all BucketingAttributes to ExperienceManager' is duplicated with different commit hashes. This usually indicates a messy merge or duplicate commits with the same intent. It should be cleaned up to maintain a concise and professional changelog.
| * adding cookie (exist , not exist) conditions ([f5529c3](https://github.com/convertcom/javascript-sdk/commit/f5529c3d82988ff5896082d14e1404db85f401cb)) | ||
| * adding cookie (exist , not exist) conditions ([8183b67](https://github.com/convertcom/javascript-sdk/commit/8183b67d4aeb22a2627f07b60313cc3dc8b844d7)) |
There was a problem hiding this comment.
The feature entry for 'adding cookie (exist , not exist) conditions' is duplicated. Please remove the redundant entry to keep the changelog clean.
| * automated TS Serving API update ([c379e1d](https://github.com/convertcom/javascript-sdk/commit/c379e1dccde7e095c33e4a17affa6ae1f914c248)) | ||
| * automated TS Serving API update ([273990d](https://github.com/convertcom/javascript-sdk/commit/273990d7727e4b1e738a33a5bfa1508c2e8c5716)) | ||
| * automated TS Serving API update ([892ff4c](https://github.com/convertcom/javascript-sdk/commit/892ff4cd1d5815103eb5fc25ff99ce35f1a401f1)) |
There was a problem hiding this comment.
The feature entry 'automated TS Serving API update' is triplicated with different commit hashes. This should be consolidated into a single entry.
| * adding cookie (exist , not exist) conditions ([f5529c3](https://github.com/convertcom/javascript-sdk/commit/f5529c3d82988ff5896082d14e1404db85f401cb)) | ||
| * adding cookie (exist , not exist) conditions ([8183b67](https://github.com/convertcom/javascript-sdk/commit/8183b67d4aeb22a2627f07b60313cc3dc8b844d7)) |
There was a problem hiding this comment.
The feature entry for 'adding cookie (exist , not exist) conditions' is duplicated. Please remove the redundant entry.
2 participants
No description provided.