Main convert - #392
Merged
Merged
Conversation
…e HTTP The User-Agent invariant introduced in #387 (always announce `ConvertAgent/1.0` on server-side outbound HTTP from HttpClient) is a js-sdk-level behavioral guarantee surfaced through every manager (api/data/event) that delegates to @convertcom/js-sdk-utils' HttpClient. Surfaces the contract at the SDK entry point so the metrics-endpoint isbot bypass dependency is documented at the layer customers integrate against, not only at the transport layer. Refs: #387
…elease fix(js-sdk): document ConvertAgent UA invariant (trigger js-sdk release)
|
JosephSamirL
approved these changes
May 25, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the file header in packages/js-sdk/src/core.ts to document the invariant User-Agent header (ConvertAgent/1.0) used by the SDK for server-side HTTP requests. This documentation clarifies that the header is required for metrics endpoint bot bypass and cannot be configured by users. There were no review comments provided, so I have no feedback to offer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.