chore(ci): remove redundant publish job from release-please.yml - #396
Merged
Merged
Conversation
The `publish` job duplicated `publish-package.yml` (which now publishes via npm Trusted Publishers / OIDC after #395) and was the last consumer of the `NPM_TOKEN` secret. `release-please.yml` now only manages versions, changelogs, tags, and GitHub Releases; the `release: published` event continues to trigger `publish-package.yml` for the actual npm publish. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
JosephSamirL
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publishmatrix job from.github/workflows/release-please.yml, which duplicatedpublish-package.ymland was the last consumer of theNPM_TOKENsecret.release-please.ymlnow does only what its name suggests: manages versions, changelogs, tags, and GitHub Releases. The actual npm publish stays inpublish-package.yml, which since fix(ci): switch publish-package.yml to npm Trusted Publishers (OIDC) #395 publishes via npm Trusted Publishers (OIDC).outputsblock on thereleasejob (releases_created/paths_released) — nothing consumes it anymore.Why this is safe
Future merges to
mainwill behave exactly as before:main→ release-please opens/updates the Release PR.js-sdk-v4.4.3) and creates a GitHub Release for each.release: publishedevent triggerspublish-package.yml→ OIDC publish to npm.The only thing that goes away is a second, racing publish path that authenticated with
NPM_TOKENand could only publish 2 of the 13 packages (the same gap that motivated #395).Follow-up (not in this PR)
NPM_TOKENrepo secret can be deleted from repo settings.Test plan
main(release-please should still update its Release PR).publish-package.ymlruns once per release and publishes successfully via OIDC.🤖 Generated with Claude Code