Ruby: Revise rule about braces #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eagletmt
reviewed
Apr 13, 2020
ruby.ja.md
Outdated
| @@ -379,14 +379,26 @@ Ruby プログラマとしての素養をある程度備えている者なら誰 | |||
| - その他、DSL のために用意されていると考えられるメソッド。 | |||
| - メソッド呼び出しを入れ子にする場合、他の規則で禁止されている場合を除いて、最も外側のメソッド呼び出しの括弧を省略してもよい。 | |||
| - **[MUST]** メソッド名とメソッド呼び出しの括弧の間に空白を入れてはならない。 | |||
| - **[SHOULD]** パラメータリストの末尾にハッシュリテラルを書く場合は、ハッシュリテラルの括弧を省略すること。 | |||
| - **[SHOULD]** メソッド呼び出しでは、キーワード引数に渡しているのかハッシュオブジェクトを渡しているのかを区別する。 | |||
There was a problem hiding this comment.
https://github.com/cookpad/styleguide/blob/590bca6dafc9f879518fc0190f0d023387066e31/ruby.ja.md#%E6%96%87%E5%AD%97%E3%82%A8%E3%83%B3%E3%82%B3%E3%83%BC%E3%83%87%E3%82%A3%E3%83%B3%E3%82%B0%E3%81%A8%E3%83%9E%E3%82%B8%E3%83%83%E3%82%AF%E3%82%B3%E3%83%A1%E3%83%B3%E3%83%88 の「Ruby 2.0 以降は UTF-8 がデフォルトになったので」と同様に、「Ruby 3 以降はキーワード引数とハッシュオブジェクトが区別されるようになるので」みたいな理由付けがあると分かりやすそう。
|
@eagletmt https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/ を参考に「分離」という言葉を使って理由を書いてみました。 |
eagletmt
approved these changes
Apr 13, 2020
nekketsuuu
force-pushed
the
nekketsuuu-BracesAroundHashParameters
branch
from
8820289 to
8ea42fb
Compare
|
レビューありがとうございました。マージします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request revises the following rule for Ruby:
Context: See #60.
This PR closes #60.