Repository navigation
Fix rule edit form deleting the rule instead of updating it - #95
Merged
akouryy merged 1 commit intoJul 24, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes an unintended DELETE request when submitting the rule edit form by eliminating nested forms caused by using button_to (which generates its own <form>) inside the main edit <form>.
Changes:
- Moves the “Transfer” link and “Delete”
button_toout of the main rule edit form to prevent nested-form behavior from hijacking_method=delete. - Adjusts layout to keep action buttons visually aligned (currently via a negative top margin on the new action row).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .column.is-2= button_to "Delete", rule_path(@rule), method: :delete, data: { confirm: %(Delete "#{@rule.name}"?) }, class: "button is-danger" | ||
|
|
||
| - if @rule.persisted? | ||
| .columns{style: "margin-top: -4rem"} |
nekketsuuu
approved these changes
Jul 24, 2026
nekketsuuu
left a comment
nekketsuuu
left a comment
Contributor
There was a problem hiding this comment.
I'll leave the design up to you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, submitting the rule edit form deletes the rule instead of updating it.
The Delete button is a
button_to, which renders its own form, so this nests a form in another form.In such cases browsers drop the inner
<form>and make its hidden input_method=deletebelong to the parent.Therefore, every submission of the rule edit form sends a DELETE request.
To fix this, this PR moves the Delete and Transfer buttons out of the edit form.
A negative margin keeps them on the same row as the Update button, but is optional. If you don't care about visual compatibility, I can remove it.