Skip to content

PPOP-242 [gateway] [api-v1] fix: solve file upload issue for big files #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

PPOP-242 [gateway] [api-v1] fix: solve file upload issue for big files #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
041e5ae
[PPOP-242] fix: add env vars in compose to manage max file size to be…
thomasAtCoopengo Sep 18, 2023
aef9ed6
[PPOP-242] docs: update changelog files
thomasAtCoopengo Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG_EN
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
* FIX#PPOP-242 Add env vars in compose to manage max file size to be handled
* BUG#PROCK-541 Add configuration for maximum mongo db cache size
* FIX#PCLAS-19 Add missing table and change ssn hash method
* FEA#PINTE-24735 Change user ID to match with the user ID in coog dockerfile
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG_FR
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
* FIX#PPOP-242 Ajout des variables d'environnement dans les fichiers compose pour gérer la taille maximales des fichiers pouvant être upload
Copy link
Contributor

@SylvainEmonet SylvainEmonet Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* FIX#PPOP-242 Ajout des variables d'environnement dans les fichiers compose pour gérer la taille maximales des fichiers pouvant être upload
* FIX#PPOP-242 Ajout des variables d'environnement dans les fichiers compose pour gérer la taille maximale des fichiers pouvant être upload

* BUG#PROCK-541 Ajout d'une configuration / limite sur la taille maximum du cache de mongo db
* FIX#PCLAS-19 Ajout des tables manquantes et modification du hash ssn
* FEA#PINTE-24735 Mise à jour de l'ID utilisateur pour correspondre à celui dans le dockerfile de coog
Expand Down
2 changes: 2 additions & 0 deletions compose/api/api_v1.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ services:

- DEBUG=${API_DEBUG_LEVEL:?}

- COOG_API_PAYLOAD_LIMIT=${COOG_API_PAYLOAD_LIMIT:?}

- OPENTELEMETRY_ENABLED=${OPEN_TELEMETRY_TRACING_ENABLED:?}
- OPENTELEMETRY_URL=${OPEN_TELEMETRY_TRACING_URL:-}
- OPENTELEMETRY_TOKEN=${OPEN_TELEMETRY_TRACING_TOKEN:-}
Expand Down
2 changes: 2 additions & 0 deletions compose/api/gateway.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ services:
- JWT_EXPIRATION=${JWT_EXPIRATION:?}
- JWT_INTERNAL_ENCRYPTION=${JWT_INTERNAL_ENCRYPTION:?}

- MAX_LIMIT_FILE_SIZE_UPLOAD=${MAX_LIMIT_FILE_SIZE_UPLOAD:?}
Copy link
Contributor

@SylvainEmonet SylvainEmonet Oct 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- MAX_LIMIT_FILE_SIZE_UPLOAD=${MAX_LIMIT_FILE_SIZE_UPLOAD:?}
- MAX_LIMIT_FILE_SIZE_UPLOAD=${MAX_LIMIT_FILE_SIZE_UPLOAD:?}


- MONGO_HOST=${MONGO_HOST:?}
- MONGO_PORT=${MONGO_PORT:?}
- MONGO_USER=${MONGO_USER:?}
Expand Down
6 changes: 6 additions & 0 deletions env.custom.sample
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,6 +230,12 @@ FILESYSTEM_ROOT= # Root directory where data will
# Whitelist for CORS, defaults to MAIN_URL_SCHEME://PROJECT_HOSTNAME
# CORS_WHITELIST=

# Use this variable to fix the limit size of files passed through the gateway
# MAX_LIMIT_FILE_SIZE_UPLOAD=

# Use this to fix the max size of files passed to the API-v1 (coog-web)
# COOG_API_PAYLOAD_LIMIT=

###############################################################################
# OpenTelemetry configuration #
###############################################################################
Expand Down