fix: parse new answer when --skip-answered is used
#1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1739 +/- ##
==========================================
- Coverage 97.75% 97.64% -0.11%
==========================================
Files 49 49
Lines 5068 5096 +28
==========================================
+ Hits 4954 4976 +22
- Misses 114 120 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sisp
force-pushed
the
fix/skip-answered-parse-answer
branch
from
fcb4031
to
a419368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed a bug where a recopy/update with
-A, --skip-answereddid not parse a new answer passed via-d, --data. The solution was simple: Skipping a question because of-A, --skip-answeredneeds to happen after parsing a new answer via-d, --datatakes place, so that using the new answer takes precedence over skipping it.Fixes #1728.