Merged
Conversation
Haven't touched mixins yet or platforms. Also need to figure out rendering for some things
…hats left now is rendering code i believe
Another round of clean-up and debugging is needed once we get the build running
Things to note: - Mixins in forge remaps differently - BakedModel in forge has extra fields because of forge-specific ModelData
Starlight causes crashes when contraptions are assembled. There's no reason for us to support Starlight anymore
Create forgot to include virtual model data when rendering transparent ghost blocks
Also fix nbt issues on existing worlds
This reverts commit 4431db7.
and change some wrappedrenderworld things to try and fix the bug
These were for the CopycatMaterialStore, which is removed in favor of AuxiliaryLightManager in neoforge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Work for the 1.21 update. Will be merged when completed