fix(admin): point calibration dashboard at this brain's holder (brain, not garry)#40
Merged
Merged
Conversation
…lways garry) The admin calibration panel showed "Cold start / No profile" even though a profile exists. gbrain's `/admin/api/calibration/profile` (and the chart endpoints) default the holder to `garry` (its personal-brain origin), but this team brain holds its calibration profile under `brain` (the take-extractor default — there is no people/garry here). So the dashboard was reading an empty garry profile. adminConfig gains `calibrationHolder` (env ADMIN_CALIBRATION_HOLDER, default `brain`); adminFetch injects it on the calibration profile endpoint when the caller didn't specify a holder, and adminFetchChart sets it on the SVG chart endpoints. typecheck + vitest (71) + next build all green. Co-Authored-By: Zypher Agent <zypher@corespeed.io>
spinsirr
force-pushed
the
fix/calibration-holder-brain
branch
from
9126379 to
b4b6600
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Calibration panel showed Cold start / No profile despite a real profile existing.
Root cause: gbrain's
/admin/api/calibration/profile(+ chart endpoints) default the holder togarry(its personal-brain origin). This team brain holds its calibration profile underbrain(the take-extractor default — no people/garry here), so the dashboard read an empty garry profile.Fix:
adminConfig.calibrationHolder(envADMIN_CALIBRATION_HOLDER, defaultbrain);adminFetchinjects it on the profile endpoint when no holder is given,adminFetchChartsets it on the chart SVGs.Verified: typecheck clean, vitest 71 pass,
next buildok. Server-only lib change; no client/secret surface touched. Deploys to gbrain-ui on merge.