-
Notifications
You must be signed in to change notification settings - Fork 5
fix: propagate client metadata to the gateway #141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nicholaspun-wandb
wants to merge
1
commit into
main
Choose a base branch
from
npun/wire-client-metadata
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+118
−9
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| # SPDX-FileCopyrightText: 2025 CoreWeave, Inc. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # SPDX-PackageName: cwsandbox-client | ||
|
|
||
| """Request-scoped client metadata sent as gRPC metadata.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| from importlib import metadata as importlib_metadata | ||
|
|
||
| HEADER_CWSANDBOX_CLIENT_VERSION = "x-cwsandbox-client-version" | ||
| HEADER_SANDBOX_INTEGRATION = "x-sandbox-integration" | ||
|
|
||
| _INTEGRATION_METADATA_VALUE = "" | ||
|
|
||
|
|
||
| def _cwsandbox_version() -> str: | ||
| try: | ||
| return importlib_metadata.version("cwsandbox") | ||
| except importlib_metadata.PackageNotFoundError: | ||
| from cwsandbox import __version__ | ||
|
|
||
| return __version__ | ||
|
|
||
|
|
||
| def set_integration_metadata(integration: str) -> None: | ||
| """Set the integration name attached to future sandbox API requests. | ||
|
|
||
| The value is process-global and optional. Passing an empty string clears the | ||
| integration metadata. | ||
| """ | ||
| global _INTEGRATION_METADATA_VALUE | ||
| _INTEGRATION_METADATA_VALUE = integration | ||
|
|
||
|
|
||
| def _reset_client_metadata_for_testing() -> None: | ||
| """Reset process-global client metadata for unit-test isolation.""" | ||
| set_integration_metadata("") | ||
|
|
||
|
|
||
| def client_metadata_headers() -> tuple[tuple[str, str], ...]: | ||
| """Return cwsandbox-managed client metadata headers.""" | ||
| headers = [(HEADER_CWSANDBOX_CLIENT_VERSION, _cwsandbox_version())] | ||
| if _INTEGRATION_METADATA_VALUE: | ||
| headers.append((HEADER_SANDBOX_INTEGRATION, _INTEGRATION_METADATA_VALUE)) | ||
| return tuple(headers) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to be used by external callers like the wandb library? If so we should import it within
__init__.py, like we do forset_auth_mode.