Skip to content

Fix CI lint failure by preallocating parseSampleGroups result slice #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Breee merged 2 commits into from
May 26, 2026
Merged

Fix CI lint failure by preallocating parseSampleGroups result slice #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85b7f25
Initial plan
Copilot May 26, 2026
b762bc5
Preallocate sample groups slice for lint
Copilot May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion hack/gen-ai-docs/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,6 @@ func buildKnowledge(root string) Knowledge {

// parseSampleGroups splits dev-samples.yaml into logical groups by comment headers.
func parseSampleGroups(raw string) []SampleGroup {
var groups []SampleGroup
lines := strings.Split(raw, "\n")

type docBlock struct {
Expand Down Expand Up @@ -305,6 +304,7 @@ func parseSampleGroups(raw string) []SampleGroup {
"CachedImageSet": "CachedImageSet manages a group of images to cache, optionally backed by a DiscoveryPolicy.",
"DiscoveryPolicy": "DiscoveryPolicy automatically discovers images from registries or Prometheus metrics.",
}
groups := make([]SampleGroup, 0, len(kindOrder))
for _, kind := range kindOrder {
g := kindGroups[kind]
g.Description = descriptions[kind]
Expand Down
Loading