Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure codebase to follow modern Rust practices #40

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

morr0ne
Copy link
Contributor

@morr0ne morr0ne commented Mar 5, 2025

While this appears to be a large PR, it's primarily focused on reorganizing the codebase structure to follow modern Rust practices and establish a solid foundation for future development.

Key changes:

  • Moved libcorn to the top level directory
  • Relocated CLI to dedicated cli folder (no extra lib.rs needed)
  • Updated tests and CI configuration to work with the new structure
  • Added release profile with proper optimizations
  • Updated bench configurations to require appropriate features
  • Refined feature declarations to use proper dependency syntax
  • Cleaned up and formatted files

Note: It'd recommend to pull this PR locally for review as GitHub's diff view may not clearly represent the structural changes.

Depends on #39

CHANGELOG.md Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume an automatic MD formatter was run on this file? Output looks the same so not concerned, just interested

Copy link
Collaborator

@JakeStanger JakeStanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few very minor comments, mostly about comments. I'm yet to check in-editor but generally lgtm, cheers again.

Are you able to rebase this one too pls?

@morr0ne morr0ne requested a review from JakeStanger March 5, 2025 14:13
@JakeStanger JakeStanger merged commit 257c7b4 into corn-config:master Mar 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants