Skip to content

Fullstack signup flow#235

Open
johnnyyliang wants to merge 8 commits intomainfrom
johnny/fullstack-signup
Open

Fullstack signup flow#235
johnnyyliang wants to merge 8 commits intomainfrom
johnny/fullstack-signup

Conversation

@johnnyyliang
Copy link
Contributor

Summary

Users are able to sign up from the fr*ntend and once signed up, are sent to their dashboard.

Testing

Went through sign up, successfully populated firebase and postgres on successful signup. Also correctly didn't allow for signup if not all fields were filled in.

Screenshot 2025-10-30 at 11 00 32 PM Screenshot 2025-10-30 at 11 01 02 PM Screenshot 2025-10-30 at 11 01 38 PM Screenshot 2025-10-30 at 11 01 58 PM Screenshot 2025-10-30 at 11 02 17 PM Screenshot 2025-10-30 at 11 02 27 PM

Notes

  • Ticket wanted to show that JWT token is active, but signup backend route doesn't return a JWT token. I implemented the JWT token in my earlier PR for signup controller and route if we want to reuse that but currently doesn't support JWT tokens
  • Added some new fields in signup, namely organization name and organization description to match backend routes, not sure how we feel about location/look
  • Moved some of the logic for verifying all fields are filled in on the last page to handleSignUp and changed type of "Create your workspace" to button, rather than submit because it wouldn't create users in Postgres (I'm guessing it's bc of handleNext, but not entirely sure)

Copy link
Collaborator

@nfq2 nfq2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to show an error pop up when account creation fails
image

@johnnyyliang
Copy link
Contributor Author

Screenshot 2025-11-06 at 3 02 39 PM

Fixed the issue with password error handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants