Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
We implemented the sign up -> login -> landing page pipeline by making the sign up page link to the log in page once a user's account is made. Then, from the login page, a user can only proceed to the landing page if their account exists in the database (which it will if they signed up).
We also integrated the forgot password pipeline by first sending an email to a user to reset their password if a user with the same email is in the database. Then the link that they get in their email will link them to the change password page. On the change password page they should be able to change their password to go to the login page and log in with their new password, but the changing password feature has not been implemented yet due to issues with Supabase.
Testing
We checked that the sign up page linked to the login page once an email was made. Then we checked using multiple emails that the login page only allowed users in the database with the correct email to access the landing page.
We tested that the forgot email page sent an email with the correct link when given an email of a user in the database using multiple emails. Additionally, we tested that the linked change email page still retained the email of the user for password changing capabilities.
Impact
Users can now efficiently sign up for an account and login to the website. Additionally, they can more easily change their passwords if they forgot it for better website use.
Screenshots
Login Page (wrong password)
3)
Reset password email

Change password page (what the email links to)

Notes
The change password implementation didn't work due to the supabase being very weird. When that is implemented, then this ticket is done.