feat: add configurable name validation scheme (legacy or utf8) #6890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 7h3-3mp7y-m4n <[email protected]>
Signed-off-by: 7h3-3mp7y-m4n <[email protected]>
7h3-3mp7y-m4n
changed the title
yeya24
reviewed
Jul 22, 2025
There was a problem hiding this comment.
https://github.com/cortexproject/cortex/blob/master/pkg/cortex/configinit/init.go
also needs to be removed. And please remove the places where the package is imported
yeya24
reviewed
Jul 22, 2025
yeya24
reviewed
Jul 23, 2025
There was a problem hiding this comment.
Let's also remove https://github.com/cortexproject/cortex/blob/master/pkg/cortex/configinit/init.go and its references.
Also fix lint then we are good to go!
| @@ -146,7 +149,7 @@ func (c *Config) RegisterFlags(f *flag.FlagSet) { | |||
| f.BoolVar(&c.AuthEnabled, "auth.enabled", true, "Set to false to disable auth.") | |||
| f.BoolVar(&c.PrintConfig, "print.config", false, "Print the config and exit.") | |||
| f.StringVar(&c.HTTPPrefix, "http.prefix", "/api/prom", "HTTP path prefix for Cortex API.") | |||
|
|
|||
| f.StringVar(&c.NameValidationScheme, "name.validation_scheme", "legacy", "Validation scheme for metric and label names. Set to utf8 to allow UTF-8 characters.") | |||
There was a problem hiding this comment.
The flag name should be name.validation-scheme as we use - in the flag name and use _ in the config file
There was a problem hiding this comment.
okay, I'll make the changes :)
7h3-3mp7y-m4n
force-pushed
the
ticket6702
branch
from
4f0a9a3 to
7da904b
Compare
|
I made a blunder, I'll raise a new PR with the changes, and I apologize for it ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds name_validation_scheme as a YAML config field and -name.validation_scheme as a CLI flag to configure the metric and label name validation mode. Supports legacy (default) and UTF-8 options.
Which issue(s) this PR fixes:
Fixes #6702
Follow Up #6733
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]