Merged
Conversation
feature/EBSVC-3503
There was a problem hiding this comment.
Pull request overview
Release 8.1 updates Cortside.AspNetCore packages/tools and expands exception-to-HTTP response handling, along with repo script/editor quality-of-life updates.
Changes:
- Update NuGet dependencies across projects (Cortside.* libs, analyzers, Swashbuckle, IdentityModel, test tooling) and add
ReferenceTrimmer. - Add 401 response handling for
UnauthorizedResponseExceptionand extend unit test scenarios accordingly. - Refresh repo automation scripts (format/coverage/clean/release tooling), add
.vscodetasks/settings, and update release metadata files.
Reviewed changes
Copilot reviewed 26 out of 28 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| update-nugetpackages.ps1 | Refactors package add/remove logic into helper functions and adjusts dotnet outdated usage. |
| src/Cortside.AspNetCore/Filters/MessageExceptionResponseFilter.cs | Adds UnauthorizedResponseException mapping to HTTP 401 responses. |
| src/Cortside.AspNetCore/Cortside.AspNetCore.csproj | Bumps package versions and adds ReferenceTrimmer. |
| src/Cortside.AspNetCore.Tests/MessageExceptionResponseFilterTest.cs | Updates expected error text and expands exception/status-code test scenarios. |
| src/Cortside.AspNetCore.Tests/Cortside.AspNetCore.Tests.csproj | Updates test project dependencies and adds ReferenceTrimmer. |
| src/Cortside.AspNetCore.Testing/Cortside.AspNetCore.Testing.csproj | Updates testing dependencies (notably WireMock) and Cortside libs. |
| src/Cortside.AspNetCore.Swagger/Cortside.AspNetCore.Swagger.csproj | Updates Asp.Versioning + Swashbuckle and adds analyzer/tooling packages. |
| src/Cortside.AspNetCore.EntityFramework/Cortside.AspNetCore.EntityFramework.csproj | Updates EF/config package versions and analyzer/tooling packages. |
| src/Cortside.AspNetCore.EntityFramework.Tests/Cortside.AspNetCore.EntityFramework.Tests.csproj | Updates test/analyzer packages and EF InMemory version. |
| src/Cortside.AspNetCore.Correlation/Cortside.AspNetCore.Correlation.csproj | Adds ReferenceTrimmer to correlation project. |
| src/Cortside.AspNetCore.Correlation.Tests/Cortside.AspNetCore.Correlation.Tests.csproj | Adds ReferenceTrimmer to correlation test project. |
| src/Cortside.AspNetCore.Common/Cortside.AspNetCore.Common.csproj | Updates Cortside.Common.Messages + analyzer/tooling packages. |
| src/Cortside.AspNetCore.Auditable/Cortside.AspNetCore.Auditable.csproj | Updates Cortside.Common.Security + EF abstractions and analyzer/tooling packages. |
| src/Cortside.AspNetCore.ApplicationInsights/Cortside.AspNetCore.ApplicationInsights.csproj | Updates Cortside.Common.Validation + analyzer/tooling packages. |
| src/Cortside.AspNetCore.AccessControl/Cortside.AspNetCore.AccessControl.csproj | Updates Cortside.RestApiClient, PolicyServer, IdentityModel, JwtBearer and analyzer/tooling packages. |
| src/Cortside.AspNetCore.AccessControl.Tests/Cortside.AspNetCore.AccessControl.Tests.csproj | Updates test/analyzer packages. |
| repository.psm1 | Introduces shared PowerShell helpers for repository configuration/JSON merging/formatting. |
| format.ps1 | Switches formatting invocation to dotnet format and simplifies args. |
| create-release.ps1 | Uses repository.psm1 and replaces echo with Write-Output. |
| coverage.ps1 | Replaces rm alias with Remove-Item. |
| clean.ps1 | Replaces rm alias with Remove-Item. |
| appveyor.yml | Updates build version to 8.1 and rotates NuGet deploy key. |
| CHANGELOG.md | Adds Release 8.1 changelog block. |
| .vscode/tasks.json | Adds VS Code tasks for restore/build/test/format and line ending helpers. |
| .vscode/settings.json | Adds repo VS Code settings (EditorConfig, formatOnSave behavior, default solution glob). |
| .vscode/launch.json | Adds minimal .NET launch configuration. |
| .vscode/extensions.json | Recommends .NET/EditorConfig extensions. |
| .gitignore | Stops ignoring publish/, removes blanket .vscode/* ignore, and adds ignores for event/amqp json artifacts. |
Comments suppressed due to low confidence (2)
src/Cortside.AspNetCore.Correlation/Cortside.AspNetCore.Correlation.csproj:23
- This project now adds
ReferenceTrimmer, but its analyzer/test tooling package versions (e.g.,Microsoft.VisualStudio.Threading.Analyzers17.8.14,Roslynator.Analyzers4.13.0,SonarAnalyzer.CSharp10.6.0.109712) are much older than the versions updated elsewhere in this PR. If the intent is to standardize on the newer analyzer versions, bump these here as well to avoid inconsistent tooling across projects.
<PackageReference Include="ReferenceTrimmer" Version="3.4.5">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Roslynator.Analyzers" Version="4.13.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="SonarAnalyzer.CSharp" Version="10.6.0.109712">
src/Cortside.AspNetCore.Correlation.Tests/Cortside.AspNetCore.Correlation.Tests.csproj:32
- This test project adds
ReferenceTrimmerbut still pins very old versions of the SDK/analyzers and even xUnit packages (e.g.,Microsoft.NET.Test.Sdk17.8.0,Microsoft.VisualStudio.Threading.Analyzers17.8.14,Roslynator.Analyzers4.13.0,SonarAnalyzer.CSharp10.6.0.109712). Most other projects were updated to newer versions in this PR; consider aligning versions here too to keep build/test behavior consistent across the solution.
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
<PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.8.14">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="ReferenceTrimmer" Version="3.4.5">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Roslynator.Analyzers" Version="4.13.0">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="SonarAnalyzer.CSharp" Version="10.6.0.109712">
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="xunit" Version="2.6.5" />
<PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
<PrivateAssets>all</PrivateAssets>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+8
to
+16
| function Remove-NuGetPackageFromProjects { | ||
| param ( | ||
| [string]$RootPath = ".", | ||
| [string]$filter = "*.csproj", | ||
| [string]$PackageName | ||
| ) | ||
|
|
||
| Get-ChildItem -Filter $filter -Recurse | ForEach-Object { | ||
| $file = $_ |
Comment on lines
+11
to
+14
| "args": [ | ||
| "restore", | ||
| "${workspaceFolder}/src/Cortside.Common.sln" | ||
| ], |
| echo "should create the pr here -- everything passed - $branch" | ||
| echo $body | ||
| Write-Output "should create the pr here -- everything passed - $branch" | ||
| Write-Output $body |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release 8.1