Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recreated the ipywwt widget to align more fully with the features of the original pywwt widget. In doing so, the
SelectionTool
has been refactored to be a full Solara component. Likewise, some changes have occurred for theDistanceTool
component as well (though it remains ipywidget-based).With the new ipywwt widget, there is a clear callback defined for when the wwt front-end is finished loading and ready to receive messages. This has allowed for implementing a loading spinner before rendering, as well as for removing some of the timers we had implemented to attempt awaiting the state of the wwt front-end.
We also now mount the wwt app in its own iframe, which requires having a separate process for hosting a local WWT instance. This instance will be used for any other widget which references the WWT research app.
This also seems to have resolved issues #840 and #447, but I encourage others to pull down this PR and give it a spin.