Use spacebar for play/pause functionality #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johnarban, thanks for pointing this out. I did some googling and it seems like the most commonly recommended keyboard control for media is to use the spacebar for play/pause, so we'll have to decide how to handle this conflict. I'm still googling and not seeing any solutions yet. |
|
@Carifio24 suggests that we detect if one of the checkboxes is the active element. If yes, apply the space bar to check/uncheck the box. (or any other element that wants to use the space-bar). If nothing else that uses space bar is active, make space bar play/pause. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the spacebar for play pause. Taking this over has the secondary effect that spacebar cannot be used for toggling the checkmark or other things. this seems like an accessiblity concern. the checkboxes indicate the space or enter are valid, but then it won't be.