Skip to content

Commit

Permalink
Fix parsing of invalid asterix symbol after private field symbol (jer…
Browse files Browse the repository at this point in the history
…ryscript-project#5155)

Raise syntax error instead of crashing.

JerryScript-DCO-1.0-Signed-off-by: Ádám Kulcsár [email protected]
  • Loading branch information
kulcsaradam authored Aug 14, 2024
1 parent 2dbb6f7 commit de51531
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
2 changes: 1 addition & 1 deletion jerry-core/parser/js/js-parser-expr.c
Original file line number Diff line number Diff line change
Expand Up @@ -689,7 +689,7 @@ parser_parse_class_body (parser_context_t *context_p, /**< context */
is_private = true;
}

if (!lexer_consume_generator (context_p))
if (is_private || !lexer_consume_generator (context_p))
{
lexer_expect_object_literal_id (context_p, ident_opts);
}
Expand Down
15 changes: 15 additions & 0 deletions tests/jerry/fail/regression-test-issue-5153.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright JS Foundation and other contributors, http://js.foundation
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

class C { async #*method() }

0 comments on commit de51531

Please sign in to comment.