Require protocol to be set in endpoint URLs #1527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
force-pushed
the
short-denoms
branch
2 times, most recently
from
a3e1e70
to
852093c
Compare
webmaster128
force-pushed
the
short-denoms
branch
from
852093c
to
b0ccb04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an app I am running into errors like this:
This is very confusing since no wwebsocket connection is used here. "ws://websocket/" probably just means the RPC string was empty and "ws://" was prepended and "websocket/" was appended.
It should not be too much to ask the app developer to always include the protocol in the URLs.