-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: merge v0.50.10 changes #21834
Conversation
Co-authored-by: beer-1 <[email protected]> Co-authored-by: Facundo <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…#20960) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…) (#20970) Co-authored-by: Julien Robert <[email protected]>
…ort #21006) (#21008) Co-authored-by: son trinh <[email protected]>
…) (#21080) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]>
… (backport #21084) (#21111) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: sontrinh16 <[email protected]>
…21073) (#21130) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Julien Robert <[email protected]> Co-authored-by: Facundo <[email protected]>
Co-authored-by: Christoph Otter <[email protected]> Co-authored-by: Julien Robert <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…(backport #21159) (#21162) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: marbar3778 <[email protected]> Co-authored-by: Facundo <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…1234) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Adam Tucker <[email protected]> Co-authored-by: marbar3778 <[email protected]>
#21264) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…#21268) Co-authored-by: Tom <[email protected]> Co-authored-by: Julien Robert <[email protected]>
…1294) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…ock (backport #21256) (#21323) Co-authored-by: Facundo Medica <[email protected]> Co-authored-by: Facundo <[email protected]>
…21329) (#21335) Co-authored-by: Julien Robert <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: KI <[email protected]>
…#21465) Co-authored-by: Julien Robert <[email protected]>
…kport #21712) (#21798) Co-authored-by: Julien Robert <[email protected]>
…21816) (#21818) Co-authored-by: Julien Robert <[email protected]> Co-authored-by: marbar3778 <[email protected]>
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WithHeaderHash(req.Hash)) | ||
} | ||
|
||
if err := app.preBlock(req); err != nil { | ||
preblockEvents, err := app.preBlock(req) | ||
if err != nil { | ||
return nil, err | ||
} | ||
|
||
events = append(events, preblockEvents...) | ||
|
||
beginBlock, err := app.beginBlock(req) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change potentially affects state.
Call sequence:
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).internalFinalizeBlock (baseapp/abci.go:692)
(*github.com/cosmos/cosmos-sdk/baseapp.BaseApp).FinalizeBlock (baseapp/abci.go:853)
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
in the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.
I have...