deps!: use cosmos-sdk v47-lsm and ics 3.3.x-lsm #2920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
requested review from
alexanderbez,
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
mpoke
approved these changes
Feb 1, 2024
| @@ -234,3 +234,5 @@ replace ( | |||
| // the following version across all dependencies. | |||
| google.golang.org/grpc => google.golang.org/grpc v1.54.0 | |||
| ) | |||
|
|
|||
| replace github.com/cosmos/interchain-security/v3 => github.com/cosmos/interchain-security/v3 v3.3.1-0.20240201164551-bde0df5adfef | |||
There was a problem hiding this comment.
nit: move in the replace block and add a docstring
There was a problem hiding this comment.
It's not the final version. We'll have to change it at least once more. I'll address the nit when we have releases (or candidates cut). Unless you feel strongly about this
insumity
approved these changes
Feb 1, 2024
sainoe
approved these changes
Feb 1, 2024
|
Wait a bit with the merge. Fixing a test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related: #2916
Use cosmos-sdk v47-lsm and matching ICS v.3.3.x-lsm.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...