Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Added ICA Controller to Gaia #3001

Merged
merged 4 commits into from
Mar 25, 2024
Merged

feat!: Added ICA Controller to Gaia #3001

merged 4 commits into from
Mar 25, 2024

Conversation

dusan-maksimovic
Copy link
Contributor

Description

Closes: #2979

ICA Controller sub-module is added to the app.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • Included the correct type prefix in the PR title
  • Added ! to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump)
  • Targeted the correct branch (see PR Targeting)
  • Provided a link to the relevant issue or specification
  • Followed the guidelines for building SDK modules
  • Included the necessary unit and integration tests
  • Added a changelog entry in .changelog (for details, see contributing guidelines)
  • Included comments for documenting Go code
  • Updated the relevant documentation or specification
  • Reviewed "Files changed" and left comments if necessary
  • Confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage

Co-authored-by: Stana Miric <[email protected]>
@MSalopek MSalopek linked an issue Mar 18, 2024 that may be closed by this pull request
5 tasks
@sainoe sainoe self-requested a review March 19, 2024 14:41
Copy link
Contributor

@MSalopek MSalopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

There may be merge conflicts with #3002

@MSalopek MSalopek merged commit 4ae0ee3 into main Mar 25, 2024
17 checks passed
@MSalopek MSalopek deleted the ica-controller branch March 25, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable the ICA controller on Gaia Enable ICA controller
4 participants