test: Add integration test for ICS epochs #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sainoe
commented
Apr 3, 2024
sainoe
requested review from
alexanderbez,
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
MSalopek
approved these changes
Apr 3, 2024
MSalopek
requested changes
Apr 3, 2024
MSalopek
approved these changes
Apr 5, 2024
insumity
reviewed
Apr 5, 2024
| delegateFn(provCtx) | ||
| // Second VSCPacket should only be created at the end of the current epoch | ||
| require.Empty(t, getVSCPacketsFn()) | ||
| require.Empty(t, getVSCPacketsFn()) |
There was a problem hiding this comment.
Why do we have two Empty calls here?
insumity
reviewed
Apr 5, 2024
| return providerKeeper.GetPendingVSCPackets(provCtx, ccvSuite.GetCCVPath().EndpointA.Chain.ChainID) | ||
| } | ||
|
|
||
| nextEpochs := func(ctx sdk.Context) sdk.Context { |
There was a problem hiding this comment.
nit: nextEpochs to nextEpoch because it seems to just "move" the system by one epoch.
insumity
reviewed
Apr 5, 2024
| ctx = ccvSuite.GetProviderChain().GetContext() | ||
| } | ||
| } | ||
| fmt.Println(app.StakingKeeper.GetLastTotalPower(provCtx)) |
There was a problem hiding this comment.
Do we need the fmt.Printlns here and below?
insumity
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially closes: #3010
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API, client, or state breaking change (i.e., requires minor or major version bump).changelog(for details, see contributing guidelines)Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change