deps!: use fixed cosmwasm version (v0.51.0) #3230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSalopek
requested review from
zmanian,
crodriguezvega,
jackzampolin and
a team
as code owners
p-offtermatt
approved these changes
Jul 29, 2024
dusan-maksimovic
approved these changes
Jul 29, 2024
MSalopek
added
A:backport/v21.x
state-machine-breaking
mergify bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
* deps!: use fixed cosmwasm version (v0.51.0) * update build * update makefile * update upgrade test with wasmvm version * update upgrade test with wasmvm version * update upgrade test with wasmvm version * update upgrade test with wasmvm version * fix: handle tests broken by libwasmvm * update simtests app dir * appease linter * update simtests app dir * appease linter * apply nits (cherry picked from commit 59574b5)
MSalopek
added a commit
that referenced
this pull request
Jul 29, 2024
* deps!: use fixed cosmwasm version (v0.51.0) (#3230) * deps!: use fixed cosmwasm version (v0.51.0) * update build * update makefile * update upgrade test with wasmvm version * update upgrade test with wasmvm version * update upgrade test with wasmvm version * update upgrade test with wasmvm version * fix: handle tests broken by libwasmvm * update simtests app dir * appease linter * update simtests app dir * appease linter * apply nits (cherry picked from commit 59574b5) * bump changelogs --------- Co-authored-by: MSalopek <[email protected]>
Reecepbcups
reviewed
Aug 2, 2024
| @@ -469,6 +468,7 @@ func NewAppKeeper( | |||
| // Must be called on PFMRouter AFTER TransferKeeper initialized | |||
| appKeepers.PFMRouterKeeper.SetTransferKeeper(appKeepers.TransferKeeper) | |||
|
|
|||
| wasmDir := filepath.Join(homePath, "wasm") | |||
There was a problem hiding this comment.
:(
ref: same issue as I did on Juno: CosmosContracts/juno#961
|
New CI test needs to be written to ensure this does not happen again: Write a CI which uploads, and executes/queries a contract. This can not be caught if you upload a new contract, since it saved to the new (incorrect) directory. Which is easy to overlook |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasmdv0.50.x seems to have a regression that breaks amino signing on execute messages. The issue affects cosmos hub testnets runninggaiad v19.0.0-rc0- mainnet is unaffected.It seems that
wamd v0.50.xis a broken release that did not get retracted so it can still be imported.Nothing in the release notes suggested that it was a broken.
Context: