-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: Add upgrade handler #3610
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjermundgaraba
approved these changes
Mar 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
app/upgrades/v23/upgrades.go
Outdated
|
||
"github.com/cosmos/gaia/v23/app/keepers" | ||
) | ||
|
||
// CreateRCUpgradeHandler returns an upgrade handler for Gaia v23.0.0-rc3. | ||
// This should only be executed on networks which |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which?
vladjdk
approved these changes
Mar 7, 2025
mergify bot
pushed a commit
that referenced
this pull request
Mar 7, 2025
* Add upgrade * Format * Add address * Fix upgrade * Remove eth light client * Fix comment * Fix upgrades (cherry picked from commit f38a3a9)
Eric-Warehime
added a commit
that referenced
this pull request
Mar 7, 2025
* Add upgrade * Format * Add address * Fix upgrade * Remove eth light client * Fix comment * Fix upgrades (cherry picked from commit f38a3a9) Co-authored-by: Eric Warehime <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an upgrade handler for in addition to the existing v23 handler. For networks which have already run the existing v23 upgrade, they can use the new RC upgrade handler, and for networks which have run neither, they can run the v23 upgrade handler in its entirety.