Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: miscellaneous for v0.52 to compile #7298

Draft
wants to merge 11 commits into
base: marko/env
Choose a base branch
from

Conversation

Reecepbcups
Copy link
Member

@Reecepbcups Reecepbcups commented Sep 16, 2024

Description

merges into marko/env (v0.52)

In order for ICT work to continue with IBC-Go v9 integration, strangelove-ventures/interchaintest#1252, IBC-Go must compile with v9 so we can import (even if incorrect, it's fine for now).

Many places are are converted properly, others are left with // TODO: comments

This PR fixes a bunch of non compile issues or comments them out for the time being so I can get unblocked. Its very possible we just close this PR. Just want is as a reference point to use with ICT :)


closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against the correct branch (see CONTRIBUTING.md).
  • Linked to GitHub issue with discussion and accepted design, OR link to spec that describes this work.
  • Code follows the module structure standards and Go style guide.
  • Wrote unit and integration tests.
  • Updated relevant documentation (docs/).
  • Added relevant godoc comments.
  • Provide a conventional commit message to follow the repository standards.
  • Include a descriptive changelog entry when appropriate. This may be left to the discretion of the PR reviewers. (e.g. chores should be omitted from changelog)
  • Re-reviewed Files changed in the GitHub PR explorer.
  • Review SonarCloud Report in the comment section below once CI passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant