feat: added ics27-2 gmp application #8352
Conversation
|
keep it up... |
| Status: channeltypesv2.PacketStatus_Failure, | ||
| } | ||
| } | ||
| if payload.Version != types.Version { |
There was a problem hiding this comment.
Should this check exist in SendPacket
|
|
||
| // getOrCreateICS27Account retrieves an existing ICS27 account or creates a new one if it doesn't exist. | ||
| func (k Keeper) getOrCreateICS27Account(ctx context.Context, accountID *types.AccountIdentifier) (*types.ICS27Account, error) { | ||
| existingIcs27Account, err := k.Accounts.Get(ctx, collections.Join3(accountID.ClientId, accountID.Sender, accountID.Salt)) |
There was a problem hiding this comment.
Why do you have this additional storage out of state?
There was a problem hiding this comment.
Seems redundant with accountKeeper
|
|
||
| // CacheContext returns a new context with the multi-store branched into a cached storage object | ||
| // writeCache is called only if all msgs succeed, performing state transitions atomically | ||
| cacheCtx, writeCache := ctx.CacheContext() |
There was a problem hiding this comment.
No gas limit, should this be in the tx passed into the payload?
| } | ||
|
|
||
| // CosmosTx contains a list of sdk.Msg's. It should be used when sending transactions to an SDK host chain. | ||
| message CosmosTx { |
There was a problem hiding this comment.
Should this use the standardized message cosmos uses?
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8352 +/- ##
==========================================
- Coverage 58.31% 56.37% -1.94%
==========================================
Files 319 335 +16
Lines 22821 23605 +784
==========================================
Hits 13307 13307
- Misses 8907 9691 +784
Partials 607 607
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.