`AV-56565 Docsearch - handle results from the new Algolia docsearch #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix filter of records with no title Change slash to right chevron U+203A Single Right-Pointing Angle Quotation Mark (instead of `>`, partly to avoid escaping it in HTML/meta tag...)
dgnicholson
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Algolia docsearch is hosted on https://docsearch.algolia.com/ and uses the Algolia crawler infrastructure.
While it's similar to "Legacy Docsearch v2" which we run on AWS EC2, it doesn't seem to return the records in exactly the format that the client .js library was expecting.
(This might be my bad for misconfiguring it? Either way, we have to handle the results arriving in an unexpected shape which:
This commit:
Fix filter of records with no title
simplifies the Component Version parsing (e.g. "java-sdk", 3.1).
I didn't really understand the existing logic, and in the meantime, our UI is exporting the data in more easily parseable structures.
So, though this doesn't look like a like-for-like translation, I think we'll retain the same features...
Change slash to right chevron, as requested by Website team (to be consistent with how the other index sources are showing breadcrumbs)
Uses U+203A Single Right-Pointing Angle Quotation Mark
(instead of
>, partly to avoid escaping it in HTML/meta tag...)