feat(create-atomic): allow Coveo atomic to start from an existing Platform Search page #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution @ThibodeauJF !
|
|
Pull Request Report PR Title ✅ Title follows the conventional commit spec. |
ThibodeauJF
commented
Mar 29, 2022
ThibodeauJF
requested review from
liviarett,
olamothe,
louis-bompart,
y-lakhdar and
btaillon-coveo
btaillon-coveo
approved these changes
Mar 29, 2022
There was a problem hiding this comment.
looks nice overall, still some changes regarding the network call.
- Move the call to the
platform-client, afaik/imho, there are no reasons for not doing so as soon those conditions are fulfilled:- The call is available outside the intranet
- The Admin UI or the CLI (or another of their JS components) need it.
This is important to prevent code duplication across the company.
- Support proxy.
Co-authored-by: Louis Bompart <[email protected]>
ThibodeauJF
commented
May 19, 2022
about the custom prompt, please double-check that your promises are properly awaited.
louis-bompart
approved these changes
May 26, 2022
louis-bompart
previously requested changes
May 26, 2022
louis-bompart
approved these changes
May 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://coveord.atlassian.net/browse/CDX-988
SIS implementation https://github.com/coveo/search-interface-service/pull/389
Platform client implementation coveo/platform-client#440
Proposed changes
Adds the possibility to specify a page id in the prompts, which will call the /manifest endpoint and pull the existing Atomic interface into the new project.
Breaking changes
None
Testing
Yes!