-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(securitycache): new list call with identity name & type filters #469
Merged
yhattab-coveo
merged 5 commits into
master
from
feature/SECCACHE-841-add-new-filter-call-to-platform-client-library
Jun 21, 2022
Merged
feat(securitycache): new list call with identity name & type filters #469
yhattab-coveo
merged 5 commits into
master
from
feature/SECCACHE-841-add-new-filter-call-to-platform-client-library
Jun 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added support for new Security Cache list call that allows to search and filter for an identity name and/or a specific type, this call will live alongside the exisiting one for now but in the future all options will come together in the new call and the old one will be deprecated. (cherry picked from commit 37583aae83be5f473aec67f08a4500e8b6072429)
toofff
reviewed
Jun 14, 2022
toofff
reviewed
Jun 14, 2022
paulgerold
reviewed
Jun 16, 2022
pdoyon-coveo
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
karanatcoveo
approved these changes
Jun 20, 2022
louis-bompart
approved these changes
Jun 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, small suggestion and that's all :)
Applying PR suggestion Co-authored-by: Louis Bompart <[email protected]>
82456b1
to
7dbaede
Compare
🎉 This PR is included in version 33.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for new Security Cache list call that allows to search and filter for an identity name
and/or a specific type, this call will live alongside the exisiting one for now but in the future
all options will come together in the new call and the old one will be deprecated.
Acceptance Criteria