Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(securitycache): new list call with identity name & type filters #469

Conversation

yhattab-coveo
Copy link
Contributor

Added support for new Security Cache list call that allows to search and filter for an identity name
and/or a specific type, this call will live alongside the exisiting one for now but in the future
all options will come together in the new call and the old one will be deprecated.

Acceptance Criteria

  • JSDoc annotates each property added in the exported interfaces
  • The proposed changes are covered by unit tests
  • Commits containing breaking changes a properly identified as such
  • README.md is adjusted to reflect the proposed changes (if relevant)

Added support for new Security Cache list call that allows to search and filter for an identity name
and/or a specific type, this call will live alongside the exisiting one for now but in the future
all options will come together in the new call and the old one will be deprecated.

(cherry picked from commit 37583aae83be5f473aec67f08a4500e8b6072429)
@yhattab-coveo yhattab-coveo requested a review from a team as a code owner June 14, 2022 17:18
@yhattab-coveo yhattab-coveo requested review from olamothe and toofff June 14, 2022 17:18
@toofff toofff requested a review from paulgerold June 16, 2022 14:40
Copy link

@pdoyon-coveo pdoyon-coveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@louis-bompart louis-bompart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, small suggestion and that's all :)

@yhattab-coveo yhattab-coveo force-pushed the feature/SECCACHE-841-add-new-filter-call-to-platform-client-library branch from 82456b1 to 7dbaede Compare June 20, 2022 20:22
@yhattab-coveo yhattab-coveo merged commit 3f6c4a7 into master Jun 21, 2022
@yhattab-coveo yhattab-coveo deleted the feature/SECCACHE-841-add-new-filter-call-to-platform-client-library branch June 21, 2022 12:57
@coveobot
Copy link

🎉 This PR is included in version 33.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants