-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(quantic): SFINT-5832 Sort E2E tests migrate from Cypress to Playwright #4777
Conversation
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
SSR Progress
Detailed logssearch : buildInteractiveResultsearch : buildInteractiveInstantResult search : buildInteractiveRecentResult search : buildInteractiveCitation search : buildGeneratedAnswer recommendation : missing SSR support case-assist : missing SSR support insight : missing SSR support commerce : missing SSR support |
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/sortObject.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/sortObject.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/sortObject.ts
Outdated
Show resolved
Hide resolved
@erocheleau I will integrate the content from this PR: #4782 in this PR as well, to have more unit tests to test the component rather going E2E only. |
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/pageObject.ts
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-read the comments that were addressed, ltgm! thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not done yet :)
Will review the playwright tests later
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/sortObject.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/sortObject.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/__tests__/quanticSort.test.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/__tests__/quanticSort.test.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/__tests__/quanticSort.test.js
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/__tests__/quanticSort.test.js
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/fixture.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/pageObject.ts
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/pageObject.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/pageObject.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still the need to not have our e2e break if we change the sort options names or labels ;)
Otherwise a few things to resolve still.
packages/quantic/force-app/main/default/lwc/quanticSort/__tests__/quanticSort.test.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/__tests__/quanticSort.test.js
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/__tests__/quanticSort.test.js
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Outdated
Show resolved
Hide resolved
packages/quantic/force-app/main/default/lwc/quanticSort/e2e/quanticSort.e2e.ts
Outdated
Show resolved
Hide resolved
…anticSort.e2e.ts Co-authored-by: Simon Milord <[email protected]>
…s__/quanticSort.test.js Co-authored-by: Etienne Rocheleau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ty @lvu285 !!!
https://coveord.atlassian.net/browse/SFINT-5832
IN THIS PR:
UNIT TESTS:
E2E PLAYWRIGHT TESTS: