Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(quantic): SFINT-5832 Sort E2E tests migrate from Cypress to Playwright #4777

Merged
merged 13 commits into from
Feb 11, 2025

Conversation

lvu285
Copy link
Contributor

@lvu285 lvu285 commented Dec 6, 2024

https://coveord.atlassian.net/browse/SFINT-5832

IN THIS PR:

  • Added Playwright E2E tests for the quantic-sort component

UNIT TESTS:

  • No need, as UTs already there

E2E PLAYWRIGHT TESTS:

  • Playwright for Sort component

@lvu285 lvu285 requested a review from a team as a code owner December 6, 2024 21:51
Copy link

github-actions bot commented Dec 6, 2024

Pull Request Report

PR Title

❌ Title should follow the conventional commit spec:
<type>(optional scope): <description>

Example: feat(headless): add result-list controller

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244 244 0
commerce 355.3 355.3 0
search 415.2 415.2 0
insight 406.4 406.4 0
recommendation 256.2 256.2 0
ssr 409 409 0
ssr-commerce 373 373 0

SSR Progress

Use case SSR (#) CSR (#) Progress (%)
search 39 44 89
recommendation 0 4 0
case-assist 0 6 0
insight 0 27 0
commerce 0 15 0
Detailed logs search : buildInteractiveResult
search : buildInteractiveInstantResult
search : buildInteractiveRecentResult
search : buildInteractiveCitation
search : buildGeneratedAnswer
recommendation : missing SSR support
case-assist : missing SSR support
insight : missing SSR support
commerce : missing SSR support

@lvu285 lvu285 changed the title SFINT-5832: Sorts e2e migrate from Cypress to Playwright SFINT-5832: Sort E2E tests migrate from Cypress to Playwright Dec 6, 2024
@mmitiche
Copy link
Contributor

@erocheleau I will integrate the content from this PR: #4782 in this PR as well, to have more unit tests to test the component rather going E2E only.

@lvu285 lvu285 requested a review from mmitiche December 27, 2024 22:16
@lvu285 lvu285 requested a review from erocheleau January 6, 2025 14:43
Copy link
Contributor

@SimonMilord SimonMilord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-read the comments that were addressed, ltgm! thank you

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not done yet :)

Will review the playwright tests later

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions

@lvu285 lvu285 requested a review from erocheleau January 29, 2025 15:43
@lvu285 lvu285 changed the title SFINT-5832: Sort E2E tests migrate from Cypress to Playwright test(quantic): SFINT-5832 Sort E2E tests migrate from Cypress to Playwright Feb 4, 2025
Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still the need to not have our e2e break if we change the sort options names or labels ;)

Otherwise a few things to resolve still.

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty @lvu285 !!!

@lvu285 lvu285 added this pull request to the merge queue Feb 11, 2025
Merged via the queue into master with commit 9c846ba Feb 11, 2025
101 checks passed
@lvu285 lvu285 deleted the SFINT-5832-SortComponent-Playwright branch February 11, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants