fix(headless, atomic): ensure components are enabled/disabled correctly when an invalid tab id is provided #4944
+121
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request ReportPR Title❌ Title should follow the conventional commit spec: Example: Live demo linksBundle Size
|
fpbrault
commented
Feb 6, 2025
...less/src/controllers/core/search-parameter-manager/headless-core-search-parameter-manager.ts
Show resolved
Hide resolved
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
requested review from
olamothe,
y-lakhdar,
fbeaudoincoveo and
alexprudhomme
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
fpbrault
temporarily deployed
to
PR Artifacts
GitHub Actions
Inactive
alexprudhomme
approved these changes
Feb 24, 2025
packages/headless/src/controllers/search-parameter-manager/headless-search-parameter-manager.ts
Show resolved
Hide resolved
packages/quantic/force-app/examples/main/lwc/exampleQuanticAriaLive/exampleQuanticAriaLive.html
Show resolved
Hide resolved
fbeaudoincoveo
approved these changes
Feb 25, 2025
| @@ -98,3 +101,8 @@ export const restoreSearchParameters = createAction( | |||
| (payload: SearchParameters) => | |||
There was a problem hiding this comment.
Since tabs are now restored through a distinct action, should we mark the tab property in the SearchParameters interface as deprecated, or maybe even remove it altogether?
| @@ -98,3 +101,8 @@ export const restoreSearchParameters = createAction( | |||
| (payload: SearchParameters) => | |||
| validatePayload(payload, searchParametersDefinition) | |||
| ); | |||
|
|
|||
| export const restoreTab = createAction( | |||
There was a problem hiding this comment.
The new action should be exposed in the public interface through the search-parameters-actions-loader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that when providing an invalid tab value, the active tab correctly falls back to the first available tab, with the tab-specific components enabled/disabled based on which tab is active.
https://coveord.atlassian.net/browse/KIT-3945