Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: build working again on windows #4954

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

chore: build working again on windows #4954

wants to merge 9 commits into from

Conversation

louis-bompart
Copy link
Collaborator

No description provided.

@louis-bompart louis-bompart requested a review from a team as a code owner February 10, 2025 21:49
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 10, 2025 •
edited
Loading

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 243.7 243.7 0
commerce 357 357 0
search 415.1 415.1 0
insight 406.2 406.2 0
recommendation 255.9 255.9 0
ssr 408.8 408.8 0
ssr-commerce 373.5 373.5 0

fbeaudoincoveo
fbeaudoincoveo approved these changes Feb 11, 2025
View reviewed changes
fbeaudoincoveo
fbeaudoincoveo approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@fbeaudoincoveo fbeaudoincoveo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this affects release logic, let's be extra careful with the next depoyment once this is merged.

@fpbrault fpbrault requested review from a team as code owners February 19, 2025 21:29
@dmgauthier
Copy link
Contributor

Nice PR description for a PR not in draft ! Helps a lot with the review :trollface:

@fpbrault fpbrault force-pushed the building-on-windows branch from 6bcec4a to 3ac817a Compare February 20, 2025 18:40
alexprudhomme
alexprudhomme reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@alexprudhomme alexprudhomme left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR needs a jira !

Base automatically changed from KIT-3925 to master February 25, 2025 04:11
@fpbrault fpbrault force-pushed the building-on-windows branch from 3ac817a to 5a1a539 Compare February 25, 2025 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexprudhomme alexprudhomme alexprudhomme left review comments

@fbeaudoincoveo fbeaudoincoveo fbeaudoincoveo approved these changes

@olamothe olamothe Awaiting requested review from olamothe olamothe is a code owner automatically assigned from coveo/search

@fpbrault fpbrault Awaiting requested review from fpbrault fpbrault is a code owner automatically assigned from coveo/search

@y-lakhdar y-lakhdar Awaiting requested review from y-lakhdar y-lakhdar is a code owner automatically assigned from coveo/search

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@louis-bompart @dmgauthier @fbeaudoincoveo @alexprudhomme @fpbrault