-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(headless): internalize fetch-event-source #4986
chore(headless): internalize fetch-event-source #4986
Conversation
Pull Request ReportPR Title✅ Title follows the conventional commit spec. Live demo linksBundle Size
|
Out or curiosity. |
More context could be found in this thread: https://coveo.slack.com/archives/G016TA2G485/p1738619735863479 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice thank you!
Essentially, the library is abandoned, and it's causing us issues. So, either we find an alternative library or we incorporate it. |
splits from #4921
Replace
@microsoft/fetch-event-source
.Essentially a good old copy of the sources, with our patch applied on top and some tweaks in the UT so that they work with Vitest.
Includes a copy of the LICENSE.