Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(headless): internalize fetch-event-source #4986

Merged
merged 2 commits into from
Feb 20, 2025

Conversation

louis-bompart
Copy link
Collaborator

splits from #4921

Replace @microsoft/fetch-event-source.

Essentially a good old copy of the sources, with our patch applied on top and some tweaks in the UT so that they work with Vitest.

Includes a copy of the LICENSE.

@louis-bompart louis-bompart requested review from mmitiche and a team February 19, 2025 06:19
@louis-bompart louis-bompart requested a review from a team as a code owner February 19, 2025 06:19
Copy link

Pull Request Report

PR Title

✅ Title follows the conventional commit spec.

Live demo links

Bundle Size

File Old (kb) New (kb) Change (%)
case-assist 244.2 243.7 -0.2
commerce 355.5 355 -0.1
search 415.5 415 -0.1
insight 406.7 406.2 -0.1
recommendation 256.3 255.9 -0.2
ssr 409.3 408.8 -0.1
ssr-commerce 373.2 372.7 -0.1

@dmgauthier
Copy link
Contributor

Out or curiosity.
We usually move to "externalize" utils and tools to open source alternative whenever we can. Why the other way around now ?
I read between the line that this is to fix source maps error, is there more to it ?

@mmitiche
Copy link
Contributor

Out or curiosity. We usually move to "externalize" utils and tools to open source alternative whenever we can. Why the other way around now ? I read between the line that this is to fix source maps error, is there more to it ?

More context could be found in this thread: https://coveo.slack.com/archives/G016TA2G485/p1738619735863479

Copy link
Contributor

@mmitiche mmitiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@erocheleau erocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice thank you!

@louis-bompart
Copy link
Collaborator Author

Out of curiosity. We usually move to "externalize" utils and tools to open-source alternatives whenever we can. Why the other way around now? I read between the lines that this is to fix source map errors. Is there more to it?

Essentially, the library is abandoned, and it's causing us issues. So, either we find an alternative library or we incorporate it.
The latter was "cheaper" to do essentially.

@louis-bompart louis-bompart added this pull request to the merge queue Feb 20, 2025
Merged via the queue into master with commit 12eeb66 Feb 20, 2025
125 checks passed
@louis-bompart louis-bompart deleted the chore/fetch-event-source-internalization branch February 20, 2025 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants