-
Notifications
You must be signed in to change notification settings - Fork 1
fix: bump sdk with new .finance domain #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🌐 Web query:
In Node.js, what happens when assigningprocess.env.MY_VAR = undefined? Does it delete the variable or set it to the string "undefined"?💡 Result:
Assigning process.env.MY_VAR = undefined sets the value to the string "undefined", not deleting the variable. To delete it, use delete process.env.MY_VAR. This is the documented behavior in the official Node.js documentation (v25.9.0), which states: "Assigning a property on process.env will implicitly convert the value to a string... env.test = undefined; console.log(env.test); // => 'undefined'". This behavior is deprecated, and future versions may throw an error for non-string/number/boolean values, but currently, it converts undefined to "undefined". Confirmed in Node.js GitHub issues
#48875and#9248, where developers note that assignment always stringifies the value, and delete is required to unset.Citations:
undefinedtoprocess.env.*sets a"undefined"string value nodejs/node#48875🏁 Script executed:
cat -n libs/repositories/src/datasources/coingecko.test.ts | head -50Repository: cowprotocol/bff
Length of output: 1781
Avoid restoring env vars via direct
undefinedassignment.At lines 9 and 13, restoring with direct assignment sets
"undefined"(string) whenoriginalApiKeyis absent, polluting the environment for other tests. In Node.js, assigningundefinedtoprocess.env.*coerces to the string"undefined"rather than deleting it; usedeleteinstead, as shown on line 34.Suggested fix
describe('getCoingeckoProClient', () => { const originalApiKey = process.env.COINGECKO_API_KEY; + + const restoreApiKey = () => { + if (originalApiKey === undefined) { + delete process.env.COINGECKO_API_KEY; + } else { + process.env.COINGECKO_API_KEY = originalApiKey; + } + }; beforeEach(() => { jest.resetModules(); jest.clearAllMocks(); - process.env.COINGECKO_API_KEY = originalApiKey; + restoreApiKey(); }); afterAll(() => { - process.env.COINGECKO_API_KEY = originalApiKey; + restoreApiKey(); });🤖 Prompt for AI Agents