Support reading TenderlyConfig api_key from environment variable#4332
Merged
squadgazzz merged 1 commit intomainfrom Apr 14, 2026
Merged
Support reading TenderlyConfig api_key from environment variable#4332squadgazzz merged 1 commit intomainfrom
squadgazzz merged 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
MartinquaXD
approved these changes
Apr 14, 2026
jmg-duarte
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
TenderlyConfig.api_keyfield currently deserializes as a plain string from TOML config. This means it cannot use the%ENV_VARpattern to read secrets from environment variables at runtime, unlikeCoinGeckoConfig.api_keywhich already supports this.Since PR #4225 moved price estimation into a separate crate and removed the old CLI
--tenderly-*arguments, the only way to configure Tenderly for the trade verifier is via the TOML[price-estimation.tenderly]section. Without env var support on theapi-keyfield, the API key would need to be hardcoded in the ConfigMap, which is a security concern.Changes
deserialize_string_from_envtoTenderlyConfig.api_keyso it supports the%ENV_VARpattern (same asCoinGeckoConfig.api_key)How to test
Existing tests.