fix: Keep watching local changes after suspension #2373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taratatach
force-pushed
the
fix/keep-watching-local-changes-after-suspension
branch
from
b36964f to
4d6479a
Compare
We wanted to stop watching local changes with Chokidar when macOS goes to sleep and restart when resuming but it appears the `unwatch`/`add` duo of Chokidar methods does not work as expected (i.e. they at least don't seem to be recursive). This was preventing the local watcher from doing its job after macOS resumed from sleep so we'll try not to stop watching the local changes when going to sleep. If this has advert effects on the suspension we'll try to find another way.
taratatach
force-pushed
the
fix/keep-watching-local-changes-after-suspension
branch
from
4d6479a to
10cd391
Compare
taratatach
changed the title
taratatach
deleted the
fix/keep-watching-local-changes-after-suspension
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to stop watching local changes with Chokidar when macOS goes
to sleep and restart when resuming but it appears the
unwatch/addduo of Chokidar methods does not work as expected (i.e. they at least
don't seem to be recursive).
This was preventing the local watcher from doing its job after macOS
resumed from sleep so we'll try not to stop watching the local changes
when going to sleep.
If this has advert effects on the suspension we'll try to find another
way.
Please make sure the following boxes are checked: