Skip to content

Properly deal with left hand coordinate systems in Eclipse#39

Open
cpgr wants to merge 1 commit intomasterfrom
lefthand
Open

Properly deal with left hand coordinate systems in Eclipse#39
cpgr wants to merge 1 commit intomasterfrom
lefthand

Conversation

@cpgr
Copy link
Copy Markdown
Owner

@cpgr cpgr commented Dec 3, 2023

To ensure a positive element Jacobian, the coordinate axis must be flipped (along with all properties).

@cpgr
Copy link
Copy Markdown
Owner Author

cpgr commented Dec 3, 2023

@Florian-Konrad - this branch produces the following

Screenshot 2023-12-03 at 9 35 57 pm

Can you check out this branch and double check that everything is ok?

@Florian-Konrad
Copy link
Copy Markdown

Florian-Konrad commented Dec 3, 2023 via email

To ensure a positive element Jacobian, the coordinate axis must be
flipped (along with all properties).
@Florian-Konrad
Copy link
Copy Markdown

Short feedback, the boxmodel looks good but I'm seeing some errors still with a more complex model (seems to be distorted). I also discovered that these errors seem to arise from the default export options in Petrel. Need to check more and write you a summary if I have gathered the relevant info from testing.

@Florian-Konrad
Copy link
Copy Markdown

Florian-Konrad commented Dec 14, 2023

Just to get back to you quickly. With a real model which has a rotated grid (not aligned with x,y,z axes) I get a distorted output mesh (see screenshot). I didnt find the time yet to make an example model to share with u and reproduce this problem. U probably need one to solve this right?
image

@cpgr
Copy link
Copy Markdown
Owner Author

cpgr commented Dec 17, 2023

Oh dear, that looks really wrong! If I am reading this correctly, there is a MAPAXES keyword in the .grdecl file? There must be something with the order of the transformation and then translation. I'll see if I can make a simple example to replicate this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants