Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groups export all posts #4657

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jayana-cpc
Copy link

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

@SansPapyrus683
Copy link
Contributor

oh my god an actual web dev pr
actually amazing, tysm

Copy link

stale bot commented Aug 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added the stale label Aug 7, 2024
@Vinceyou1
Copy link
Contributor

@jayana-cpc sent you a message on discord, let's review this together when you have a chance

Copy link

stale bot commented Aug 23, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added the stale label Aug 23, 2024
Copy link

stale bot commented Aug 31, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added the stale label Aug 31, 2024
Copy link

stale bot commented Sep 10, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added the stale label Sep 10, 2024
Copy link

stale bot commented Sep 29, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added the stale label Sep 29, 2024
Copy link
Member

@thecodingwizard thecodingwizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm, thanks for implementing this!

from my brief testing it seems like the posts are imported out-of-order, which is not ideal but not blocking.

Comment on lines +134 to +140
<button
type="button"
className="block w-full text-left px-4 py-2 text-sm text-gray-700 hover:bg-gray-100 hover:text-gray-900 focus:outline-none focus:bg-gray-100 focus:text-gray-900"
onClick={handleExportAllPosts}
>
Export All Posts
</button>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should only show this for owners of the group you're exporting from?

Comment on lines +170 to +186
groups.data.map(group =>
group &&
group.ownerIds.includes(firebaseUser!.uid) ? (
<div key={group.id}>
<label className="inline-flex items-center">
<input
type="checkbox"
className="form-checkbox"
onChange={() =>
handleGroupExportChange(group)
}
/>
<span className="ml-2 text-gray-500">
{group.name}
</span>
</label>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor, but I think right now it will allow you to export a group to itself, which probably isn't desireable.

@stale stale bot removed stale labels Oct 11, 2024
Copy link

stale bot commented Oct 19, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added the stale label Oct 19, 2024
Copy link

stale bot commented Nov 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. Please address the requested changes and re-request reviews. Thank you for your contribution!

@stale stale bot added the stale label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants