Update BuildingTeams PySol content/3_Silver/Graph_Traversal.mdx #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
freakin23
reviewed
Nov 10, 2024
ryanchou-dev
approved these changes
Nov 10, 2024
SansPapyrus683
requested changes
Nov 10, 2024
Comment on lines
-1223
to
-1224
| assigned = [0 for _ in range(n)] | ||
| valid = True |
There was a problem hiding this comment.
just now realizing that this is replacing an old sol
uneasy about this bc the old one was consistent w/ java and c++, while this one isn't
There was a problem hiding this comment.
Note: Updated/changed the pre-existing Python BFS solution as I had a simpler, faster solution.
Yeah, I mentioned it in the description. If that's a concern, we just just use the old one. If so, I can try to see if there are any optimizations that can be made while still keeping it consistent with the other language's solutions (unless it's exactly the same).
There was a problem hiding this comment.
I can try to see if there are any optimizations that can be made while still keeping it consistent
i'd love this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds new Python Solutions to https://cses.fi/problemset/task/1668/ for content/3_Silver/Graph_Traversal.mdx.
Relates to #3444
Runtimes
DFS (missing Python): https://cses.fi/problemset/result/11118878/ (0.74s)
Previous BFS Sol: https://cses.fi/problemset/result/11118911/ (0.90s)
New BFS Sol: https://cses.fi/problemset/result/11118910/ (0.69s)
Note: Updated/changed the pre-existing Python BFS solution as I had a simpler, faster solution.
Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.