Skip to content

Adds initial draft for translation-units topic#79

Open
rwdougla wants to merge 4 commits intocplusplus:masterfrom
rwdougla:Issue5
Open

Adds initial draft for translation-units topic#79
rwdougla wants to merge 4 commits intocplusplus:masterfrom
rwdougla:Issue5

Conversation

@rwdougla
Copy link
Copy Markdown
Contributor

@rwdougla rwdougla commented Jun 8, 2022

Issue #5

@diehlpk
Copy link
Copy Markdown
Contributor

diehlpk commented Feb 27, 2025

@vulder I looked at it and I think it ready for a review.

@vulder vulder marked this pull request as ready for review April 14, 2025 20:27
@vulder vulder changed the title straw-man draft for translation-units Adds initial draft for translation-units topic Apr 14, 2025
Copy link
Copy Markdown
Member

@vulder vulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the first draft, if we could clean up the few remarks below, we could vote on this in the next SG20 meeting.

Comment on lines +31 to +32
_TODO:
_introduce notion of object file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems from the TODO that the notion of a object files is still missing here.


#### Caveats

#### Points to cover
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently, this topic is missing points to cover.

------------------------------------------------------------------------
Level Objective
----------------- ------------------------------------------------------
Foundational
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Foundational
Foundational Building code from multiple files


A student:

1. Is able to define a variable, function, or class
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Is able to define a variable, function, or class
1. Is able to define a variable, function, and class

Maybe this should be an and, or would seeing one of those be enough?

2. Is able to access declarations from either module import or header inclusion

Questions:
modules and/or functions?
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit like a note that should be worked out?


_This section lists important details for each point._

Declarations and definitions can be within same file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Declarations and definitions can be within same file
* declarations and definitions can be within same file

_This section lists important details for each point._

Declarations and definitions can be within same file

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The points to cover seem to be missing important parts that should be covered, at least when waht I would infer from the ASSBATs section.

Comment on lines +93 to +95
3.
4.
5.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3.
4.
5.

A student should be able to:

1. explain how an anonymous namespace functions within their translation unit
2. One-definition-rule shennanigans
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intricacies might be advanced but do you not think that at least teaching the the one-definition-rule would not make sense at least on a "main" level?

@vulder vulder added the Tentatively ready Ready for a final review in SG20 label Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Tentatively ready Ready for a final review in SG20

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants