P3037R6 constexpr std::shared_ptr and friends #8010
Merged
+320
−308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was not the easiest paper to track wording to the draft sources, so even though the changes are simple, please review carefully to confirm that no |
|
As with earlier PRs, there is a problem retaining an inline comment without line-wrapping or overfilling a box if we stick to the 4-space alignment rule. I defer to Thomas to fix this issue when applying the PR. |
Eisenwave
requested changes
Jun 24, 2025
AlisdairM
force-pushed
the
apply_p3037_constexpr_shared_ptr_and_friends
branch
from
6665450 to
aa8c1f2
Compare
Eisenwave
approved these changes
Jun 25, 2025
tkoeppe
force-pushed
the
apply_p3037_constexpr_shared_ptr_and_friends
branch
from
bb6df99 to
85f8816
Compare
tkoeppe
force-pushed
the
apply_p3037_constexpr_shared_ptr_and_friends
branch
from
85f8816 to
c364535
Compare
|
This looks good, thanks a lot, Alisdair! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7941
Fixes cplusplus/papers#1713
Did not apply
constexprto deleted functions. The application in the paper was inconsistent, and I deemed the active uses as errors.Made minor whitespace and line-breaking adjustments to avoid line-wrapping and overfull hboxes.
Fixed odd use of return type on the same line as the template head for an
allocate_sharedoverload, where it belonged on the same line as the function name, before applying theconstexprkeyword.