P3348R4 C++26 should refer to C23 not C17 #8011
Conversation
Avoid lone subclause [depr.ctime] in Annex D.
jensmaurer
force-pushed
the
motions-2025-06-lwg-3
branch
from
b079059 to
73448ea
Compare
| #define @\libmacro{WEOF}@ @\seebelow@ // freestanding | ||
| #define @\libmacro{WCHAR_WIDTH}@ @\seebelow@ // freestanding |
There was a problem hiding this comment.
| #define @\libmacro{WEOF}@ @\seebelow@ // freestanding | |
| #define @\libmacro{WCHAR_WIDTH}@ @\seebelow@ // freestanding | |
| #define @\libmacro{WCHAR_WIDTH}@ @\seebelow@ // freestanding | |
| #define @\libmacro{WEOF}@ @\seebelow@ // freestanding |
The paper wants a different order for these macros.
There was a problem hiding this comment.
In [cstdint.syn] WCHAR_WIDTH comes immediately after WCHAR_MAX, because there's no WEOF in [cstdint.syn]. That's why I put it before WEOF here. It's not important though, certainly editorial.
| @@ -11658,7 +11667,7 @@ | |||
| \end{footnote} | |||
|
|
|||
| \pnum | |||
| The functions \tcode{asctime}, \tcode{ctime}, \tcode{gmtime}, and | |||
| The functions \tcode{gmtime} and | |||
| \tcode{localtime} are not required to avoid data | |||
| races\iref{res.on.data.races}. | |||
|
|
|||
There was a problem hiding this comment.
Right below, there is a missing change (GitHub won't let me comment on that line):
-\xrefc{7.27}
+\xrefc{7.29}| In addition to being available via inclusion of the \libheader{cfloat} header, | ||
| the macros \tcode{INFINITY} and \tcode{NAN} are | ||
| available when \libheaderref{cmath} is included. |
There was a problem hiding this comment.
Out of curiosity, why is it \libheader{cfloat} but \libheaderref{cmath}?
| @@ -762,6 +777,21 @@ | |||
| Equivalent to: \tcode{return visit(std::forward<Visitor>(vis), arg.value);} | |||
| \end{itemdescr} | |||
|
|
|||
| \rSec1[depr.ctime]{Deprecated time formatting} | |||
There was a problem hiding this comment.
The paper titles this subclause
Header
<ctime>synopsis
I assume the change is intentional?
There was a problem hiding this comment.
No the paper has "D.? Deprecated [depr.ctime]" and then "D.?.? Header synopsis [depr.ctime.syn]". As noted in the commit msg, the D.?.? subclause has been dissolved, so there's only D.? here, so strictly speaking the paper titled it "Deprecated".
"Deprecated" is a terrible name (I think I meant to write something there and apparently forgot). And "Header synopsis" only made sense for an rSec2 title, not the rSec1 title. So this change seems necessary.
Avoid lone subclause [depr.ctime] in Annex D.
Fixes #7940.
Fixes cplusplus/papers#2020