Skip to content

[expected.object.monadic][expected.void.monadic] Add missing necessary typename #8178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[expected.object.monadic][expected.void.monadic] Add missing necessary typename #8178

wants to merge 2 commits into from
+8 −8

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Aug 21, 2025 •
edited
Loading

Although it's unambiguous to implementors and users that T::value_type and T::error_type must be types, typename is still necessary to make the condition well-formed.

Fixes #8177.

jensmaurer
jensmaurer approved these changes Aug 21, 2025
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwakely, you seemed to be in favor in the other thread?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[expected.object.monadic] Add typename between is_same_v<U​::​error_type, E>
2 participants
@frederick-vs-ja @jensmaurer