Skip to content

Conversation

eisenwave
Copy link
Member

@eisenwave eisenwave commented Oct 3, 2025

This is a misapplication of P2996R13 cplusplus/papers#1668.

Fixes https://github.com/cplusplus/nbballot/issues/777.

The synopsis has no static (which is correct).

@jensmaurer
Copy link
Member

jensmaurer commented Oct 4, 2025

We have a special commit message format for fixes addressing NB comments:

https://github.com/cplusplus/draft/wiki/Commit-message-format

Please update + force-push.

I've also fixed your "closes" line to actually be active.

@eisenwave eisenwave added the ballot-comment Response to an NB or ISO comment on a ballot label Oct 6, 2025
@jensmaurer jensmaurer added this to the C++26 milestone Oct 6, 2025
@jensmaurer
Copy link
Member

See #8352; taking that as approval by @jwakely .

@jensmaurer jensmaurer merged commit c914b3b into cplusplus:main Oct 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ballot-comment Response to an NB or ISO comment on a ballot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants