[atomics.types.float] Align parameters in function declarations #8328
+37
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NB US 197-316 (C++26 CD).
eisenwave
commented
Oct 9, 2025
Comment on lines
-5447
to
+5459
| memory_order = memory_order::seq_cst) noexcept; | ||
| @\placeholdernc{floating-point-type}@ fetch_fmaximum_num(@\placeholdernc{floating-point-type}@, | ||
| memory_order = memory_order::seq_cst) volatile noexcept; | ||
| constexpr @\placeholdernc{floating-point-type}@ fetch_fmaximum_num(@\placeholdernc{floating-point-type}@, | ||
| memory_order = memory_order::seq_cst) noexcept; | ||
| @\placeholdernc{floating-point-type}@ fetch_fminimum_num(@\placeholdernc{floating-point-type}@, | ||
| memory_order = memory_order::seq_cst) volatile noexcept; | ||
| constexpr @\placeholdernc{floating-point-type}@ fetch_fminimum_num(@\placeholdernc{floating-point-type}@, | ||
| memory_order = memory_order::seq_cst) noexcept; | ||
| memory_order = memory_order::seq_cst) noexcept; | ||
| @\placeholdernc{floating-point-type}@ | ||
| fetch_fmaximum_num(@\placeholdernc{floating-point-type}@, | ||
| memory_order = memory_order::seq_cst) volatile noexcept; | ||
| constexpr @\placeholdernc{floating-point-type}@ | ||
| fetch_fmaximum_num(@\placeholdernc{floating-point-type}@, | ||
| memory_order = memory_order::seq_cst) noexcept; | ||
| @\placeholdernc{floating-point-type}@ | ||
| fetch_fminimum_num(@\placeholdernc{floating-point-type}@, | ||
| memory_order = memory_order::seq_cst) volatile noexcept; | ||
| constexpr @\placeholdernc{floating-point-type}@ | ||
| fetch_fminimum_num(@\placeholdernc{floating-point-type}@, | ||
| memory_order = memory_order::seq_cst) noexcept; |
There was a problem hiding this comment.
I had to make some pretty drastic changes in this place unfortunately.
floating-point-type fetch_fmaximum_num(floating-point-type,
memory_order = memory_order::seq_cst) volatile noexcept;... wouldn't have onto the page, by a handful of characters.
There was a problem hiding this comment.
I think what we usually can and do do in these situations is to break immediately after the opening paren ( and then start parameters on the next line, indented by two. Could we do that here?
There was a problem hiding this comment.
I haven't tried it, and I'm not able to for the next hours. Personally I don't like that style anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/cplusplus/nbballot/issues/891.
The parameter indentation in the subclause is broken in four different ways:
exchange,fetch_max, etc. it looks likeconstexprwas added without adding then necessary indentation to the second line of the declaration, resulting in misalignment.store_fmaximumand some others, an attempt was made to align the parameters, but unsuccessfully.fetch_key, there is one space too much indentation, and we forgot to useplaceholderncrather thanplaceholder.store_key, we just used two-space indentation rather than trying to align parameters at all.