use CPM.cmake module to fetch project_options #207
Conversation
ENABLE_CONAN by default to test conan with CPM fetch contents disable gui dependency for simlicity (and reduce buildtime)
| @@ -1,6 +1,6 @@ | |||
| find_package(Catch2 REQUIRED) | |||
|
|
|||
| include(CTest) | |||
| #XXX include(CTest) | |||
There was a problem hiding this comment.
why do you include CTest modue?
There was a problem hiding this comment.
There was a problem hiding this comment.
you want to enable submissions to a CDash server?
| # see https://github.com/cpm-cmake/CPM.cmake for more info | ||
| include(cmake/CPM.cmake) | ||
|
|
||
| # Add project_options v0.18.0, but my version! CK |
There was a problem hiding this comment.
only for test now, later original may be used!
| @@ -92,6 +101,7 @@ dynamic_project_options( | |||
| PCH_HEADERS | |||
| <vector> | |||
| <string> # This is a list of headers to pre-compile, here are some common ones | |||
| ENABLE_CONAN | |||
There was a problem hiding this comment.
I am woundering conan was not enabled?
There was a problem hiding this comment.
This is probably an artifact of the split between cpp_boilerplate_project and cpp_starter_project. Without ENABLE_CONAN here, this project cannot build at all.
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
=======================================
Coverage 80.00% 80.00%
=======================================
Files 3 3
Lines 30 30
=======================================
Hits 24 24
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I have to admit, I don't understand the purpose of this PR.
- You are removing the sdl and fltk examples. Shouldn't you be starting from the upstream https://github.com/cpp-best-practices/cpp_boilerplate_project ? That project already has the examples removed.
- CPM is certainly useful for many purposes, but I don't see why we need it here. FetchContent works just as well, and it doesn't rely on an external dependency. What are you trying to add?
|
This PR was only to tigger the ci test. |
There are other ways to trigger a ci test. See GH actions syntax here: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#onevent_nametypes I often add |
ENABLE_CONAN by default to test conan with CPM fetch contents
disable gui dependency for simlicity (and reduce buildtime)
see too aminya/project_options#116