Refactor lighthouse #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NikolaJelic
commented
Jun 17, 2025
NikolaJelic
commented
- Create Lighthouse class
- Add texture rendering with placeholder texture
- Create Lighthouse class - Add texture rendering with placeholder texture
karnkaul
reviewed
Jun 18, 2025
karnkaul
requested changes
Jun 18, 2025
- rotate lighthouse image so it better follows the cursor - adjust whitespace - fix unit vector typo
karnkaul
requested changes
Jun 18, 2025
karnkaul
requested changes
Jun 18, 2025
Add new util/random
- add targeted movement - change spawn point generation
karnkaul
requested changes
Jun 20, 2025
- move spawn point position generation to the 'util::random' namespace - add default initialization to primitives - remove redudant includes - add 'const' to local variables where appropriate - rename 'move' function to avoid naming conflicts
karnkaul
requested changes
Jun 21, 2025
karnkaul
requested changes
Jun 22, 2025
karnkaul
approved these changes
Jun 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.