Nikola/light #6
Merged
Nikola/light #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
NikolaJelic
commented
Jun 26, 2025
NikolaJelic
commented
- Extract light into a separate class
- Add simple score tracking and rendering
- Conditionally render enemies only if they are in contact with the Light
- move light to separate class - let light manage its effect on the enemies - enemies take tick damage
karnkaul
requested changes
Jun 26, 2025
- add collision parameters struct - fix collision calculation - improve text score handling - remove redundand initialization of text
karnkaul
approved these changes
Jun 27, 2025
| auto [pos, diameter] = enemy.get_pos_diameter(); | ||
| if (glm::distance(pos, m_sprite.transform.position) < (diameter + m_diameter)) { | ||
| auto const [pos, diameter] = enemy.get_collision_params(); | ||
| if (glm::distance(pos, m_sprite.transform.position) < (diameter + m_diameter) / 2) { |
There was a problem hiding this comment.
You can avoid square rooting here by comparing square magnitude instead of magnitude.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.